error_log: PHP Deprecated

JasT
Topic Author
Offline
Fresh Boarder

Posts: 8
Thank you received: 0

JasT created the topic: error_log: PHP Deprecated

Using the following version from the breezingforms.xml file info:
COM_BREEZINGFORMS
2018-03-08
(build 931)

On the following platform and version:
Joomla! 3.9.13
OS: Linux n
PHP: 7.2.25
MySQLi: 5.6.45

I see this in my error_log file:

[08-Dec-2019 23:34:01 UTC] PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in / (ANON) /plugins/content/breezingforms/breezingforms.php on line 192

the LINE 192 that it points to is:

while (list($prop, $val) = each($_REQUEST))

Please advise...

5 months 3 weeks ago #238704

mihaela
Offline
Administrator

Posts: 3128
Karma: 105
Thank you received: 413

mihaela replied the topic: error_log: PHP Deprecated

Hello,

This is rather a notice than an error message, but here is how you can remove it.

Go to JOOMLA ROOT/plugins/content/breezingforms/breezingforms.php, open the breezingforms.php file and around line 192 replace the following code:

reset($_REQUEST);
		while (list($prop, $val) = each($_REQUEST))
			if (!is_array($val) && substr($prop,0,9)=='ff_param_')
				$ff_request[$prop] = $val;

with this code:

// reset($_REQUEST);
			foreach($_REQUEST as $prop => $val) {
				if (!is_array($val) && substr($prop,0,9)=='ff_param_')
					$ff_request[$prop] = $val;
                        }

That should do the trick, the error message should be gone.

Let me know whether that resolved the issue.

Regards,

Mihaela

5 months 3 weeks ago #238710

gavinhanly
Offline
Fresh Boarder

Posts: 2
Thank you received: 0

gavinhanly replied the topic: error_log: PHP Deprecated

On this - there's another issue on line 242. How should that be changed?

while (list($prop, $val) = each($ff_request)) $url .= '&amp;'.htmlentities($prop, ENT_QUOTES, 'UTF-8').'='.htmlentities(urlencode($val), ENT_QUOTES, 'UTF-8');
	$params =   'id="ff_frame'.$form->id.'" '.
				'src="'.$url.'" '.
				$framewidth.
				$frameheight.
				'frameborder="'.htmlentities($border, ENT_QUOTES, 'UTF-8').'" '.
				'allowtransparency="true" '.
				'scrolling="no" ';

5 months 3 weeks ago #238717

JasT
Topic Author
Offline
Fresh Boarder

Posts: 8
Thank you received: 0

JasT replied the topic: error_log: PHP Deprecated

Okay, after applying your fix, I now get this new error in the error_log:

[09-Dec-2019 19:25:45 UTC] PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in / (ANON) /plugins/content/breezingforms/breezingforms.php on line 242

Please advise.

5 months 3 weeks ago #238725

mihaela
Offline
Administrator

Posts: 3128
Karma: 105
Thank you received: 413

mihaela replied the topic: error_log: PHP Deprecated

Hello,

Hello, to fix this and remove the notice go to Joomla root/plugins/content/breezingforms/breezingforms.php and in that file around line 242 replace the following code:

reset($ff_request);
    while (list($prop, $val) = each($ff_request)) $url .= '&amp;'.htmlentities($prop, ENT_QUOTES, 'UTF-8').'='.htmlentities(urlencode($val), ENT_QUOTES, 'UTF-8');

with this one:

foreach($ff_request as $prop => $val) {
        $url .= '&amp;'.htmlentities($prop, ENT_QUOTES, 'UTF-8').'='.htmlentities(urlencode($val), ENT_QUOTES, 'UTF-8');
  }

That should fix it.

NOTE: There might be more notices like this. Since these are rather notices than errors, It should not affect functionality.

To remove the message, for now, you can go to System > Global Configuration and in the Server tab set the Error Reporting to None. Save the change and the notices should be gone.

Let me know whether it resolved the problem.

Regards,

Mihaela

5 months 3 weeks ago #238734

JasT
Topic Author
Offline
Fresh Boarder

Posts: 8
Thank you received: 0

JasT replied the topic: error_log: PHP Deprecated

Thanks.

Your assumption that there would be more notices after this new change was correct. I got a new notice:

[10-Dec-2019 22:34:10 UTC] PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in / (ANON) /plugins/content/breezingforms/breezingforms.php on line 284

I think your suggestion to turn off the error reporting feature could be an issue, since I think it turns it off globally to all of Joomla possible future notices or errors.

I think (perhaps) this plugin needs an overhaul. I forget why this optional plugin is necessary, but if it's still required to use, maybe you can suggest a new fix to the new notice above, until we finally get this one in the bag. This way you can then offer a new update to that plugin?

I'm willing to go though it all, until it's finally fixed.

P.S. when I get an email notice telling me that my post was either approved or a new reply awaits, I get a very odd email that is very large, and just see a blue background screen throughout the email. And when I mean large, is that I have to scroll left and down to see the center of the email notice -- it is very huge, I mean very huge--titan huge.

5 months 3 weeks ago #238757

Moderators: ForumSupport

Time to create page: 0.051 seconds

Need a custom form?

GWS-Desk.com is Crosstec's official partner for developing custom forms

We Are Doing Our Part

Massive discounts on all of our extension subscription plans to help you and your business in these times.

Get Your Subscription Here

New Icon Packs Category!

Crosstec is now offering icon packs.

If you are a paying subscriber, icon packs are automatically added to your account.

Check out our icon packs page!

All Extensions Subscription

We are doing our part and support your business with extremely low prices -- For example 6-Months-Subscription for only $9 USD. For as long as necessary.

No support per domain or website installation limits! Includes all of our current and future Joomla!® extensions, Joomla!® templates for the duration of your membership. This means, by purchasing an All Extensions Subscription you'll have it all covered!

Get it from here

3rd Party Discount - 25% Off

We help you to keep your costs under control. If you are a new member and purchased a form building tool from a different form vendor, then you'll get a 25% discount on our subscription plans.

How to receive the discount:

Send us a quick email to sales@crosstec.org with a proof of purchase (for example a paypal receipt), await payment instructions and enjoy your membership!